• StudioLE@programming.dev
    link
    fedilink
    arrow-up
    14
    ·
    1 year ago

    My mantra has always been to bring solutions not problems. Applying that to code reviews makes for a far more productive experience.

    Rather than just pointing out errors in code help the developer with prompts towards the solution.

    Or, if you’re too lazy to explain why something shouldn’t be done then why should another developer have to act on your criticism?

    • muddi [he/him]@hexbear.net
      link
      fedilink
      English
      arrow-up
      3
      ·
      1 year ago

      Same , but in my experience this can backfire even worse because the other person thinks you are trying to show off as well as make them look bad. But the problem is less with you and me, and more with this type of person